Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XHR Request Timing Telemetry #2711

Closed
wants to merge 3 commits into from

Conversation

at-ninja
Copy link
Contributor

Create a new class, XMLHttpRequestMetrics, that implements UMA histograms for commonly tracked request timing metrics for XHR requests.

b/329439270

Change-Id: Ic4cb843f5ccf2693310becdf22bf8a8917695ce5

Create a new class, XMLHttpRequestMetrics, that implements UMA
histograms for commonly tracked request timing metrics for XHR requests.

b/329439270

Change-Id: Ic4cb843f5ccf2693310becdf22bf8a8917695ce5
Change-Id: I3c106aa1177bd5d50a30be8e4535850524c57e57
Change-Id: If52f76b3a9ffcd2e9e86244e22d3c1282989adc1
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 97.50000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 58.49%. Comparing base (4753e86) to head (2a9de01).
Report is 5 commits behind head on main.

Files Patch % Lines
cobalt/xhr/xml_http_request.cc 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2711      +/-   ##
==========================================
+ Coverage   58.45%   58.49%   +0.03%     
==========================================
  Files        1910     1912       +2     
  Lines       95092    95132      +40     
==========================================
+ Hits        55590    55647      +57     
+ Misses      39502    39485      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@at-ninja at-ninja marked this pull request as draft March 25, 2024 23:28
@at-ninja at-ninja closed this Mar 25, 2024
@at-ninja at-ninja deleted the xhr-request-metrics branch May 17, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant